Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React v19 #1113

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
fd56dc5
task: Updates for JSX Transform conversion script
meissadia Jan 16, 2025
8d3bf84
deps: Upgrade to React 19
meissadia Jan 16, 2025
c28cbbc
deps: Upgrade to React 19 types
meissadia Jan 16, 2025
3d1235d
deps: Upgrade to design-system-react running React v19
meissadia Jan 24, 2025
6293f02
e2e: Update Navigation.spec to match recent CFGov updates
meissadia Jan 24, 2025
b8ab805
task: Remove deprecated usage of defaultProps for functional components
meissadia Jan 16, 2025
cb68368
task: `useRef` requires an argument
meissadia Jan 17, 2025
9e6c88d
fix: [FormButtonGroup] Add missing `flex` class that got accidentally…
meissadia Jan 24, 2025
672d970
fix: <SectionIntro> typescript errors
meissadia Jan 27, 2025
0fdc5a9
fix: <CrumbTrail> typescript errors
meissadia Jan 27, 2025
e1052c1
fix: <AssociatedFinancialInstitution> typescript errors
meissadia Jan 27, 2025
cae8a92
fix: useIsOverflowing() typescript errors
meissadia Jan 27, 2025
71b10d4
fix: <FilingFieldLinks> typescript errors
meissadia Jan 27, 2025
84e1901
fix: <FilingHome> typescript errors
meissadia Jan 27, 2025
10b54f0
deps: Upgrade react-scroll and @types/react-scroll
meissadia Jan 27, 2025
0eb5938
deps: Upgrade @types/react, @types/react-dom
meissadia Jan 27, 2025
482495e
Merge branch 'main' into 1104-upgrade-to-react-19
meissadia Jan 27, 2025
3e98e9f
fix: <CrumbTrail> typescript errors
meissadia Jan 28, 2025
31d783c
fix: react-scroll related typescript errors
meissadia Jan 28, 2025
02ae3f2
Merge branch 'main' into 1104-upgrade-to-react-19
meissadia Jan 30, 2025
d1680b5
deps: Upgrade design-system-react to git branch #392-upgrade-to-react…
meissadia Jan 30, 2025
ed5ee92
Merge branch 'main' into 1104-upgrade-to-react-19
meissadia Feb 7, 2025
cc57fa4
Merge branch 'main' into 1104-upgrade-to-react-19
meissadia Feb 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: [FormButtonGroup] Add missing flex class that got accidentally…
… removed
meissadia committed Jan 24, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 9e6c88d11440fcd3ab665c79454ae934a4da5d4d
2 changes: 1 addition & 1 deletion src/components/FormButtonGroup.tsx
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ function FormButtonGroup({
isFilingStep = false,
children,
}: FormButtonGroupProperties & JSX.IntrinsicElements['div']): JSX.Element {
const classnames = ['mt-[1.875rem]'];
const classnames = ['mt-[1.875rem] flex'];
classnames.push(isFilingStep ? 'gap-[1.125rem]' : 'gap-[0.625rem]');
if (className) classnames.push(className);
return <div className={classnames.join(' ')}>{children}</div>;
Loading