Skip to content

Commit

Permalink
Removed 'Additional Details' from Complete your User Profile & Update…
Browse files Browse the repository at this point in the history
… your Financial Institution Profile (#592)

closes #577 

## Note
- Zod schema and formatting helper functions will be kept in -- incase
of future use


## Changes
- chore(additional_details): removed just the UI elements

## How to test this PR

1. Test Complete your User Profile (No Associations) -- verify requests
still go through with the proper data body
2. Test Update your Financial Institution Profile -- verify requests
still go through with the proper data body

## Screenshots
<img width="407" alt="Screenshot 2024-05-29 at 3 58 24 AM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/3f0ebf30-8cb0-411c-864d-02afc65ed33d">
<img width="604" alt="Screenshot 2024-05-29 at 3 55 05 AM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/e48573f0-f377-4397-aa06-7e7e6d1803e5">
  • Loading branch information
shindigira authored May 31, 2024
1 parent 0048f96 commit 4a0a57e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
3 changes: 0 additions & 3 deletions src/pages/Filing/UpdateFinancialProfile/UfpForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import type { InstitutionDetailsApiType } from 'types/formTypes';
import { Five } from 'utils/constants';
import { updateFinancialProfileKeyLogic } from 'utils/getFormErrorKeyLogic';
import getIsRoutingEnabled from 'utils/getIsRoutingEnabled';
import AdditionalDetails from './AdditionalDetails';
import FinancialInstitutionDetailsForm from './FinancialInstitutionDetailsForm';
import UpdateAffiliateInformation from './UpdateAffiliateInformation';
import UpdateIdentifyingInformation from './UpdateIdentifyingInformation';
Expand Down Expand Up @@ -147,8 +146,6 @@ export default function UFPForm({
{...{ register, formErrors, watch }}
heading='Update your parent entity information'
/>
<AdditionalDetails {...{ register }} />

<FormButtonGroup>
<Button
id='nav-submit'
Expand Down
2 changes: 0 additions & 2 deletions src/pages/ProfileForm/CreateProfileForm/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import FormMain from 'components/FormMain';
import LinkButton from 'components/LinkButton';
import SectionIntro from 'components/SectionIntro';
import { Button, Link } from 'design-system-react';
import AdditionalDetails from 'pages/Filing/UpdateFinancialProfile/AdditionalDetails';
import {
emptyAddFinancialInstitution,
formatUserProfileObject,
Expand Down Expand Up @@ -151,7 +150,6 @@ function CreateProfileForm(): JSX.Element {
Add a financial institution
</LinkButton>
</div>
<AdditionalDetails isOptional register={register} />
<FormButtonGroup>
<Button
appearance='primary'
Expand Down

0 comments on commit 4a0a57e

Please sign in to comment.