Ticket 11, added invalid_uid_lei validation and unit tests #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchen-2101
reviewed
Aug 11, 2023
lchen-2101
reviewed
Aug 11, 2023
added 3 commits
August 11, 2023 15:27
…d have a way to skip this validation
|
I think we're also adding to the phased validations schema, correct? Can you check, and add it to the phased one as well? |
Sure, adding it. |
guffee23
reviewed
Aug 16, 2023
README.md
Outdated
| @@ -27,6 +27,8 @@ failed validation. | |||
|
|
|||
| ```sh | |||
| # Test validating the "good" file | |||
| # If passing lei value, pass lei as fist arg and csv_path as second arg | |||
There was a problem hiding this comment.
Oh, let me fix.
lchen-2101
reviewed
Aug 16, 2023
added 2 commits
August 16, 2023 15:12
jcadam14
pushed a commit
that referenced
this pull request
May 3, 2024
* Ticket 11, added invalid_uid_lei validation and unit tests * changed function name * addressed Hans suggestions to have lei passed through command line and have a way to skip this validation * addressed the comments * modified comments * addressed the comment and modified the phase validation * modified function name * fixed typo * addressed the comment * Addressed the comment --------- Co-authored-by: Nargis Sultani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11