Redesign Filing Landing Page + Keycloak upgrade to version 25 #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs old. Slowly migrating keycloak-js to 25.0.6. Commit contains upgrade to version 18.0.1 and it's required migration changes.
… the operator in front of calling Keycloak instance.
… homepage before login as an error stating two Keycloak instances were being initialized. Introduced an EmergencyAlert banner at the top of the page to lets users know Login.gov will be requried - verbiage is still being worked on.
…ated EmergencyAlert to support hyperlinks to appear anywhere in the sentence.
…h See How It Works button that opens the same Homepage video modal. Adjusted Timeline CSS for mobile design.
….gov contact language.
…. Improved Filing platform styling by ensuring max-width matches the rest of the site. Working to resovle the /filing/{year}/institutions route to allow the ability to login.
…for navigation to different filing years rather then relying on the url.
…d use version 25 Keycloak methods. Disabled Quarterly Filers select in HMDA Help and updated/disabled related tests due to ticket #2319.
Michaeldremy
commented
Nov 5, 2024
src/common/constants/dev-config.json
Outdated
| "2025": { | ||
| "Q1": "04/01/2025 - 05/30/2025 - 06/30/2025", | ||
| "Q2": "07/01/2025 - 08/29/2025 - 09/30/2025", | ||
| "Q3": "10/01/2025 - 11/29/2025 - 12/31/2025", | ||
| "Q3": "10/01/2025 - 12/01/2025 - 12/31/2025", |
There was a problem hiding this comment.
If there is any questions reference ticket #2301 to see why the date is being changed.
Michaeldremy
commented
Nov 5, 2024
Comment on lines
+34
to
+35
| className='filing-year-selector' | ||
| classNamePrefix='filing-year' |
There was a problem hiding this comment.
Used to properly select the dropdown for Cypress testing.
Michaeldremy
commented
Nov 5, 2024
| @@ -44,6 +46,7 @@ const InstitutionPeriodSelector = ({ | |||
| history.replace(pathname.replace(filingPeriod, period)) | |||
| }} | |||
| isDisabled={quarterOpts.length < 2} | |||
| classNamePrefix='annual-or-quarter' | |||
There was a problem hiding this comment.
Used to properly select the dropdown for Cypress testing.
…n file. Added testDate paramerter to test future Filing Periods for the FilingPeriodsCard component. Deleted LoginGov Register method from utils/keycloak.js as it is no longer needed
…bout quarterly filers. Added the Login.gov Quick Refence Guide link.
…onally I added the reviewed timedGuards to the production config. Added a new bullet point to the Login.gov promotional banner to include login reqirement language.
…p watch. Footer was updated to 4 columns instead of 3 from the newly compiled CSS files.
…ent based on stakeholder feedback, implemented additional code cleanup surrounding Filing Landing Page. Updated Cypress Filing and LargeFiler test files and implemented a bug fix in the Filing platform UI related to the year and quarterly selectors.
… to be a darker green to improve Lighthouse accessibility score.
…ser, Maps and Graphs was forcing the user to be scrolled to the top when interacting with the the form elements. Issue has been resolved by ignoring query parameters in the URL event listener in the ScrollToTop component.
…erodsCard where the padding on the period-item was manually being set instead of respecting the parent container padding.
…h 1 falls on a Saturday in 2025.
…Props and resolved a Keycloak theme provider browser back button bug. Additionally, more padding was added below the Filing Landing Page container.
…ner script reordering to resolve a merge conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2162 & #2319
Pull request includes:
keycloaks-jswas upgraded/migrated from version 11 to version 25Quarterly Filerselect has been disabled and is no longer able to be interacted withLighthouse Scores:
Before Redesign
After Redesign