Add proper support for connection to RDS PostgreSQL #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support DATABASE_URL in either a file path or env var. Based on @chosak's work on the crawler.
Needed to connect to Postgres.
willbarton
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to configure a connection to a PostgreSQL database in AWS RDS.
It relies on a GitHub Actions repository secret named
RDS_CREDS_SECRETwhich must contain the name of an AWS secret containing the RDS database URL. This URL is passed to both the initContainer for Django migrations as well as the regular container for the Django app.See internal Website-Alto-Migration#21 for additional context.