-
Notifications
You must be signed in to change notification settings - Fork 71
Adding Design Manual content guidelines, corresponding updates to footer #440
base: gh-pages
Are you sure you want to change the base?
Conversation
Looking pretty good! I do have some notes on the content:
|
Looks good to me too! Just a couple comments:
Formatting contentPresent components of behavior, styling, use cases, etc as bullet points, to allow readers to skim content easily. Include an image or a live code example of those components as needed. Example:
|
I am making all of your suggested changes @ielerol and @sonnakim! The only one I was a little confused by/unsure about was your (2) Sonna. I'm totally down to change stuff if you think we should clarify more, but I'm not doing a good job of following which part I should change. Could you screenshot + provide a recommended sentence/words to add? Thank you!! |
Who has the power to do a final review and merge on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a front-end POV 👍
@@ -7648,8 +7648,9 @@ ul.list_links-minicons li { | |||
border-width: 0 15px; | |||
margin-right: -0.25em; | |||
vertical-align: top; | |||
width: 33.33333333%; | |||
width: 30%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops... spoke too soon. You need to make these changes to the widths in the Less code, lest they be overwritten the next time someone recompiles the Less.
That code currently defines things in terms of grid columns.
Let me know if you need further assistance with updating those.
@stephanieosan Okay, here's what I've got! Please replace the highlighted sentence below: with the bolded words here: Use dynamic content, or shortcut references to data used site-wide, to simplify the process of documenting standards. Rather than writing out the hex number for a brand palette color, you could use a dynamic content reference to automatically pull that hex number into your design manual page. This eliminates the need to copy and paste the same content again and again or to update many separate pages if standards change over time. |
@stephanieosan Could you make the content changes and I'll look into helping with the less changes. Looks like we could easily get this merged. |
Less fix is ready for review => stephanieosan#1 |
Moved css changes to the less file
@stephanieosan just wanted to bump the content change @sonnakim suggested. If you don't think you'll get to it I can try to find time today. |
Additions
These content guidelines pages aren't included in the top nav, instead we've redesigned the footer to include a link to them there.
Changes
Future considerations
Review
Check out changes here: https://stephanieosan.github.io/design-manual/content-guidelines/content-guidelines.html