DS import changes #8694
Open
DS import changes #8694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anselmbradford
requested changes
Dec 20, 2024
Co-authored-by: Ans <[email protected]>
anselmbradford
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3.6.x, the design system added an
exportskey, to allow thetippy.jslibrary to be excluded except where it's specifically used.However, when
exportsare added, the default filesystem search when an importer tries to grab a file no longer works. This is how we were importing scripts and fonts in cf.gov (and really was the only way to do it).3.6.2 added a way to import icons nicely, so this PR updates our icon and script imports to what the design-system now requires.
Testing