Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to yarn 4 #8474

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Upgrade to yarn 4 #8474

wants to merge 1 commit into from

Conversation

wpears
Copy link
Member

@wpears wpears commented Jun 14, 2024

Testing

  • Pull
  • corepack enable
  • yarn && yarn run build
  • Try adding/removing dependencies. This should work as expected

@wpears wpears requested a review from anselmbradford June 14, 2024 14:31
@wpears wpears marked this pull request as draft June 14, 2024 14:52
@anselmbradford
Copy link
Member

This is the .yarnrc.yml I landed on in cfpb/design-system#1916

enableGlobalCache: false

enableHardenedMode: true

enableMirror: true

enableOfflineMode: true

enableTelemetry: false

nodeLinker: node-modules

yarnPath: .yarn/releases/yarn-4.3.0.cjs

IIRC this is built off the defaults. FWIW the default is to put the cache in .yarn/cache. Is this something we want to do here? If not, I should probably change the cache directory in 1916.

@wpears wpears marked this pull request as ready for review June 25, 2024 02:48
@wpears
Copy link
Member Author

wpears commented Jun 25, 2024

@anselmbradford I don't think we'll need enableHardenedMode generally, and instead of defaulting to offlinemode (which seems not quite what it says on the tin), I've set the appropriate env var to disable network access in CI altogether.

@wpears wpears marked this pull request as draft June 25, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants