Tables! #1143
Merged
Tables! #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Description: | ||
|
|
||
| Create a gray well organism. |
There was a problem hiding this comment.
Note to self: just update all the documentation.
|
👍, just wondering if there should be a full-width modifier for the table. |
| </tr> | ||
| </thead> | ||
|
|
||
| {% for row in rows %} |
There was a problem hiding this comment.
This whole for loop doesn't need the extra indentation.
|
Minor comments but overall looks good. Side note, I think @KimberlyMunoz wins the CFPB PR Gifslinger award |
I think for mobile styles, we probably want the full-width to be the default. I'll open a PR on cf-tables for that. |
|
👍 |
1 similar comment
|
👍 |
Add the newest changes from cf-tables and removing old table styles Addding documentation and a better solution for loops from @sebworks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tables!
Additions
Removals
Testing
Review
Preview
Preview this PR without the whitespace changes
Notes