Add Timeline Quick View support and fix build with current SDK #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with real watches (Pebble Time Steel) and emulators (Aplite, Basalt, Chalk, Diorite). |
|
Hmm, not so easy. The modification of C code seems to work well so far. However, the buildscript for JS does not. Applying #3 makes it better, but still the name and screenshot is missing. :( |
|
As noted in #4, the issue mentioned here (i.e., bad name and missing screenshot) is probably not a real issue. But it seems you have already implemented a different solution for this, which causes a conflict. I can't try it right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Aplite and Chalk don't support this feature. This wasn't a problem with Chalk, it just ignores the code. It was, however, an issue with Aplite, because increased code size caused OOM conditions. For this reason, the code is #ifdef-ed for Aplite.