Skip to content

Inhibit management of share config.php file when mpf_disable_mission_portal_docroot_sync_from_share_gui is defined #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Feb 12, 2025

In preparation for possibly removing the share/GUI folder entirely.

Ticket: ENT-12658
Changelog: title

…portal_docroot_sync_from_share_gui is defined

In preparation for possibly removing the share/GUI folder entirely.

Ticket: ENT-12658
Changelog: title
@craigcomstock
Copy link
Contributor Author

craigcomstock commented Feb 14, 2025

blocked by cfengine/cf-remote#124, that bug is what is breaking acceptance_tests

@craigcomstock craigcomstock marked this pull request as draft February 14, 2025 13:37
@craigcomstock craigcomstock marked this pull request as ready for review February 19, 2025 16:30
@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins please, thanks.

@cf-bottom
Copy link

Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a note about packaging stuff unrelated to the policy itself.

craigcomstock added a commit to craigcomstock/buildscripts that referenced this pull request Feb 20, 2025
Related to inhibiting management of share config.php file when a class is defined.
cfengine/masterfiles#2987

Ticket: ENT-12658
Changelog: none
@craigcomstock craigcomstock merged commit 75d54b2 into cfengine:master Feb 20, 2025
34 checks passed
@craigcomstock craigcomstock deleted the ENT-12658/master branch February 20, 2025 22:53
@craigcomstock craigcomstock added the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick? Fixes which may need to be cherry-picked to LTS branches
Development

Successfully merging this pull request may close these issues.

5 participants