ENT-14398: Moved event driven cfengine into cf-reactor - #6290
Open
victormlg wants to merge 1 commit into
Open
Conversation
victormlg
force-pushed
the
agent-driven-cf-reactor
branch
from
August 14, 2026 11:17
a26acb5 to
22ff75c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /* long options only */ | ||
| case 0: | ||
| { | ||
| // const char *const option_name = OPTIONS[longopt_idx].name; |
Contributor
There was a problem hiding this comment.
There's some commented out code here
victormlg
marked this pull request as ready for review
August 18, 2026 08:09
victormlg
force-pushed
the
agent-driven-cf-reactor
branch
from
August 19, 2026 15:08
22ff75c to
4407d5a
Compare
Ticket: ENT-14398 Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
agent-driven-cf-reactor
branch
from
August 20, 2026 08:45
4407d5a to
be99f9c
Compare
larsewi
requested changes
Aug 20, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
I see that cf-watchd has some options not present here. Is this intended?
| case 'M': | ||
| { | ||
| Writer *out = FileWriter(stdout); | ||
| ManPageWrite(out, "cf-watchd", time(NULL), |
Contributor
There was a problem hiding this comment.
Suggested change
| ManPageWrite(out, "cf-watchd", time(NULL), | |
| ManPageWrite(out, "cf-reactor", time(NULL), |
| #include <platform.h> | ||
| #include <logging.h> | ||
| #include <eval_context.h> | ||
| #include <stdio.h> |
| /* long options only */ | ||
| case 0: | ||
| { | ||
| // const char *const option_name = OPTIONS[longopt_idx].name; |
Contributor
There was a problem hiding this comment.
There's some commented out code here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.