CFE-3882: Added strtotime policy function - #6237
Open
victormlg wants to merge 2 commits into
Open
Conversation
larsewi
requested changes
Jul 16, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
Please add some acceptance tests :)
olehermanse
requested changes
Jul 17, 2026
olehermanse
left a comment
olehermanse
left a comment
Member
There was a problem hiding this comment.
Yep, as @larsewi said not much to review here, please add acceptance test. Most code review is in libntech.
|
Marking this PR as stale due to inactivity; it will be closed in 7 days. |
victormlg
force-pushed
the
strtotime
branch
3 times, most recently
from
August 18, 2026 13:28
f264368 to
189600a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
victormlg
force-pushed
the
strtotime
branch
2 times, most recently
from
August 18, 2026 13:53
38e6fef to
c76539d
Compare
larsewi
requested changes
Aug 19, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
The new functions in pipes.h probably deserve their own commit.
cf_popen_exact_args is variation of cf_popen when the exact arguments are known at compile time. This skips the quote escaping of ArgSplitCommand which is needed when argv can be of arbitrary length, such as with user input Signed-off-by: Victor Moene <victor.moene@northern.tech>
Ticket: CFE-3882 Changeglog: Title Signed-off-by: Victor Moene <victor.moene@northern.tech>
larsewi
approved these changes
Aug 19, 2026
Contributor
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14538/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14538/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.