Skip to content

ENT-12600: clean-buildmachine: Documented script #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

larsewi
Copy link
Contributor

@larsewi larsewi commented Jun 20, 2025

Build with no tests
Build Status

larsewi added 2 commits June 20, 2025 15:16
I also:
- fixed shellcheck issues
- added an if statement to prevent accedental deletion root on AIX in
  case of prefix being empty or undefined
- added a debug log message

Ticket: ENT-12600
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi larsewi requested a review from craigcomstock June 23, 2025 08:59
@larsewi larsewi marked this pull request as ready for review June 23, 2025 08:59
@larsewi larsewi requested a review from olehermanse June 25, 2025 10:50
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @craigcomstock is probably more qualified :)

Comment on lines +6 to +7
# Don't run this script on your dev machine! You may accidentally delete
# something very important.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Don't run this script on your dev machine! You may accidentally delete
# something very important.
# Don't run this script on your dev machine! You may accidentally delete something very important.

Comment on lines +3 to +4
# This script cleans a build machine by uninstalling cfbuild and removing the
# contents of the PREFIX directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# This script cleans a build machine by uninstalling cfbuild and removing the
# contents of the PREFIX directory.
# This script cleans a build machine by uninstalling cfbuild and removing the contents of the PREFIX directory.

What is 'cfbuild'? ;) do you mean all the cfbuild- prefixed packages which are made by install-dependencies?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe cfbuild to you means the built items in $PREFIX, typically /var/cfengine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants