Skip to content

ENT-12185: Moved CFE_ROBOT user creation from MP cli task to shell script & Print setup code in the postinstall scripts#1628

Merged
craigcomstock merged 2 commits intocfengine:masterfrom
aleksandrychev:ENT-12185
Apr 4, 2025
Merged

ENT-12185: Moved CFE_ROBOT user creation from MP cli task to shell script & Print setup code in the postinstall scripts#1628
craigcomstock merged 2 commits intocfengine:masterfrom
aleksandrychev:ENT-12185

Conversation

@aleksandrychev
Copy link
Contributor

@aleksandrychev aleksandrychev commented Mar 21, 2025 •
edited
Loading

@cf-bottom
Copy link

cf-bottom commented Mar 22, 2025

Thank you for submitting a pull request! Maybe @craigcomstock can review this?

@aleksandrychev aleksandrychev changed the title Removed CFE_ROBOT user creation from post install scripts Moved CFE_ROBOT user creation from MP cli task to shell script Mar 24, 2025
craigcomstock
craigcomstock reviewed Mar 24, 2025
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better would be to move this into it's own script and call that.

Currently we have docs about how to do this (https://docs.cfengine.com/docs/3.24/web-ui-hub_administration-reset-admin-creds.html#internal-credentials) but would be nice to codify it and make it "easy". Also add calling the externalized script to @olehermanse 's cfengine command!

@aleksandrychev
Moved CFE_ROBOT user creation from MP cli task to shell script
4fa374c 
ChangeLog: Title

Ticket: ENT-12185
Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
@craigcomstock
Copy link
Contributor

craigcomstock commented Mar 25, 2025

even better would be to move this into it's own script and call that.

Currently we have docs about how to do this (https://docs.cfengine.com/docs/3.24/web-ui-hub_administration-reset-admin-creds.html#internal-credentials) but would be nice to codify it and make it "easy". Also add calling the externalized script to @olehermanse 's cfengine command!

I think this PR is a good incremental change. Approved!

@aleksandrychev aleksandrychev force-pushed the ENT-12185 branch 2 times, most recently from dc47ac4 to 86efb75 Compare April 2, 2025 13:27
@aleksandrychev aleksandrychev changed the title Moved CFE_ROBOT user creation from MP cli task to shell script Moved CFE_ROBOT user creation from MP cli task to shell script & Print setup code in the postinstall scripts Apr 3, 2025
@aleksandrychev aleksandrychev changed the title Moved CFE_ROBOT user creation from MP cli task to shell script & Print setup code in the postinstall scripts ENT-12185: Moved CFE_ROBOT user creation from MP cli task to shell script & Print setup code in the postinstall scripts Apr 3, 2025
@aleksandrychev
Print setup code in the postinstall scripts
4b08c80 
Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
@craigcomstock craigcomstock merged commit 79cbfa7 into cfengine:master Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craigcomstock craigcomstock craigcomstock approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aleksandrychev @cf-bottom @craigcomstock