Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved CFE_ROBOT user creation from MP cli task to shell script #1628

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Moved CFE_ROBOT user creation from MP cli task to shell script #1628

wants to merge 1 commit into from

Conversation

aleksandrychev
Copy link
Contributor

@aleksandrychev aleksandrychev commented Mar 21, 2025 •
edited
Loading

@cf-bottom
Copy link

Thank you for submitting a pull request! Maybe @craigcomstock can review this?

@aleksandrychev aleksandrychev changed the title Removed CFE_ROBOT user creation from post install scripts Moved CFE_ROBOT user creation from MP cli task to shell script Mar 24, 2025
craigcomstock
craigcomstock reviewed Mar 24, 2025
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better would be to move this into it's own script and call that.

Currently we have docs about how to do this (https://docs.cfengine.com/docs/3.24/web-ui-hub_administration-reset-admin-creds.html#internal-credentials) but would be nice to codify it and make it "easy". Also add calling the externalized script to @olehermanse 's cfengine command!

@aleksandrychev
Moved CFE_ROBOT user creation from MP cli task to shell script
4fa374c 
ChangeLog: Title

Ticket: ENT-12185
Signed-off-by: Ihor Aleksandrychiev <[email protected]>
@craigcomstock
Copy link
Contributor

even better would be to move this into it's own script and call that.

Currently we have docs about how to do this (https://docs.cfengine.com/docs/3.24/web-ui-hub_administration-reset-admin-creds.html#internal-credentials) but would be nice to codify it and make it "easy". Also add calling the externalized script to @olehermanse 's cfengine command!

I think this PR is a good incremental change. Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigcomstock craigcomstock craigcomstock approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleksandrychev @cf-bottom @craigcomstock