Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed php module for apache, replaced with php-fpm #1604

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Removed php module for apache, replaced with php-fpm #1604

merged 1 commit into from
Mar 28, 2025

Conversation

craigcomstock
Copy link
Contributor

Ticket: ENT-12696
Changelog: none

@craigcomstock
Copy link
Contributor Author

Build Status

@craigcomstock craigcomstock marked this pull request as draft February 28, 2025 18:19
@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins please, thanks.

@craigcomstock craigcomstock marked this pull request as ready for review March 3, 2025 16:02
@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11768/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11768/

vpodzime
vpodzime reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise. Good riddance! :)

@craigcomstock
Copy link
Contributor Author

luckily I was working on a container-hub setup which built masterfiles into the buildscripts dir so when I did grep -r libphp.so I found a mention in masterfiles.

cfengine/masterfiles#2992

@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11800/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11800/

@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins

@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11806/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11806/

vpodzime
vpodzime approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@craigcomstock
Copy link
Contributor Author

The deployment test failures from the previous jenkins run seem oddly related to hostname issues during install.
I will look at the support tarballs a bit before retrying.

@craigcomstock
Removed php module for apache, replaced with php-fpm
7c6b2de 
Changed from no-debug-zts-YYYYMMDD to no-debug-non-zts-YYYYMMDD for extensions dir with the removal of the php apache module.

Ticket: ENT-12696
Changelog: none
@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11879/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11879/

@craigcomstock
Copy link
Contributor Author

Yeah, I think this is green enough.

@craigcomstock craigcomstock merged commit 7189972 into cfengine:master Mar 28, 2025
29 of 30 checks passed
@craigcomstock craigcomstock deleted the ENT-12696 branch March 28, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpodzime vpodzime vpodzime approved these changes

@aleksandrychev aleksandrychev aleksandrychev approved these changes

@nickanderson nickanderson Awaiting requested review from nickanderson

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@craigcomstock @cf-bottom @vpodzime @aleksandrychev