Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find MFA options by action URL #203

Merged
merged 2 commits into from
Jan 28, 2021

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Oct 15, 2020

@coveralls
Copy link

coveralls commented Oct 15, 2020

Coverage Status

Coverage decreased (-1.6%) to 45.89% when pulling c22f5af on cloudposse:mfa into d473d67 on cevoaustralia:master.

@andreaso
Copy link

Currently looking into catching /signin/challenge/skotp/ to cover the https://g.co/sc security key fallback.

Something which belongs in this PR/branch, or rather something we should try to get merged later separately?

@Nuru
Copy link
Contributor Author

Nuru commented Oct 19, 2020

@stevemac007 can you review and approve this PR, or bring this to the attention of someone who can?

@forsberg
Copy link

@andreaso - if I understand you correctly, you're trying to fix #202, correct?

My five cents is that what we have here should be merged ASAP as it adds stability (I can now login using TOTP, on master it's quite erratic), while getting back the Yubikey/U2F functionality would be nice but can be handled in a separate PR.

@andreaso
Copy link

Hej Erik!

Well, at least I'm trying to work-around the #202 issue, with the https://g.co/sc one-time security codes being a viable option even when TOTP, etc is disabled for your G-Suite account.

I do have something crude working under https://github.com/andreaso/aws-google-auth/tree/wip/skotp-support, which is based on this PR.

But yeah, let's get this PR merged first, while I get some further testing/improvement on my patch internally.

@gageorsburn
Copy link

Is this going to go in?

stevemac007 added a commit that referenced this pull request Jan 28, 2021
@stevemac007
Copy link
Contributor

Apols for the radio silence - 2020 was a crazy year for us all - I've got this ready to ship in the release shortly and will do work to triage the remaining outstanding issues and pr's over the coming days.

@stevemac007 stevemac007 merged commit c22f5af into cevoaustralia:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No attempt to use U2F Security Key Cannot login: MFA stopped working, then took wrong choice
6 participants