canvas: Support custom coordinate systems #719
Conversation
johannes-wolf
force-pushed
the
ctx-coordinate-resolve
branch
from
59f0465
to
d14797a
Compare
johannes-wolf
force-pushed
the
ctx-coordinate-resolve
branch
from
c23e480
to
91dd180
Compare
| @@ -116,8 +116,6 @@ | |||
| assert.eq(style.pos(), (), message: "Unexpected positional arguments: " + repr(style.pos())) | |||
| style = style.named() | |||
|
|
|||
| (a, b, c).map(coordinate.resolve-system) | |||
There was a problem hiding this comment.
I don't think these should be removed, they help tell the user where they've entered an invalid coordinate
There was a problem hiding this comment.
actually I see why they've been removed, thats a really difficult trade off.
Is there a way we could keep track of how many or which draw functions have been created and let the user know about it? Essentially create our own stack trace. It probably shouldn't go in this pr but I would like to at least explore it before this pr gets approved.
There was a problem hiding this comment.
We could add some trace list to the context, that gets shown with any panic/assert we do. Something like element information (function name + element name, if given). This might be slow though, as we have to append and merge that list for every element.
There was a problem hiding this comment.
I've created a PR for a possible implementation of such functionality here: #726.
johannes-wolf
force-pushed
the
ctx-coordinate-resolve
branch
from
91dd180
to
645b111
Compare
|
Rebased on master. |
Proposal: Add the option to use custom coordinates by providing an option to register a callback for "pre-resolving" coordinates.
Motivation: Being able to handle plot/axis coordinates differently than "normal" coordinates in
cetz-plot. But this feature could also be used to implement a tangent system on paths etc. I have not looked at the sources of fletcher, but it may be interesting to them, too.