Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server option object #12

Closed
flowersinthesand opened this issue Jul 30, 2016 · 2 comments
Closed

Server option object #12

flowersinthesand opened this issue Jul 30, 2016 · 2 comments
Assignees

Comments

@flowersinthesand
Copy link
Member

To configure options, setter methods on server that correspond to each option have been adopted for the convenience of test but working with them in runtime on production may cause unpredictable behavior.

From that point of view, a dedicated object representing options fits better in this case.

@flowersinthesand
Copy link
Member Author

Since the curren options apply to socket, a kind of socket configurer to be called in handshaking would be useful as a server option, i.e. options.socketConfigurer = (socket, headers) => {/* return configuration object including heartbeat for the given socket*/}

@flowersinthesand
Copy link
Member Author

Follwing cettia/cettia-java-server#11 (comment), I will revert commits regarding this issue.

@flowersinthesand flowersinthesand removed this from the 1.0.0-RC1 milestone May 4, 2017
flowersinthesand added a commit that referenced this issue May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant