Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerOptions class #11

Open
flowersinthesand opened this issue Jul 30, 2016 · 1 comment
Open

ServerOptions class #11

flowersinthesand opened this issue Jul 30, 2016 · 1 comment

Comments

@flowersinthesand
Copy link
Member

As pointed in cettia/cettia-protocol#12, introducing a dedicated class to represent options about server, i.e. ServerOptions, would be better in Java as well.
@flowersinthesand flowersinthesand added this to the 1.0.0-RC1 milestone Jul 30, 2016
@flowersinthesand flowersinthesand self-assigned this May 4, 2017
@flowersinthesand
Copy link
Member Author

On second thought, it seems to be excessive to introduce a new class and create relationship between other classes just for one option, i.e. heartbeat. It would be wise to wait for the feedback regarding this issue.

I'll remove it from the milestone. Sorry for the confusion.

@flowersinthesand flowersinthesand removed this from the 1.0.0-RC1 milestone May 4, 2017
@flowersinthesand flowersinthesand mentioned this issue May 4, 2017
Closed
@flowersinthesand flowersinthesand removed their assignment Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flowersinthesand