Separating presentational and container components #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrellin
force-pushed
the
react_component_refactor
branch
6 times, most recently
from
401318e
to
4254417
Compare
|
Is it definitely necessary to have everything in its own directory? It's hard for me to see the advantage of that. |
|
@bnaul I think the idea is to eventually put all of the redux code
(actions, reducers, etc) related to each component into that component's respective
directory.
…On Monday, August 7, 2017, Brett Naul ***@***.***> wrote:
Is it definitely necessary to have everything in its own directory? It's
hard for me to see the advantage of that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#225 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG5TTRbWUiuGoMnLo-4NWKdsts3QrvQVks5sVypagaJpZM4OuLNq>
.
|
acrellin
force-pushed
the
react_component_refactor
branch
2 times, most recently
from
376486f
to
fab7aad
Compare
bnaul
force-pushed
the
master
branch
4 times, most recently
from
afacff9
to
1640cac
Compare
acrellin
force-pushed
the
react_component_refactor
branch
from
b843883
to
c8bdbe2
Compare
|
Closes #255 |
|
@acrellin I haven't thought about this for a while, but Andy mentioned https://github.com/react-boilerplate/react-boilerplate to me in cesium-ml/baselayer#41 It may be worth to just double check how they do things (for all I know it's the same as in this refactor). |
|
@stefanv Looks like we're using the same structure |
… separate directories
…ntainer) component files
acrellin
force-pushed
the
react_component_refactor
branch
from
72c15d6
to
bd341c0
Compare
acrellin
changed the title
|
@stefanv this is ready for review |
acrellin
force-pushed
the
master
branch
4 times, most recently
from
36a6dcc
to
e4eb913
Compare
|
We've now moved to functional components + redux logic in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the
Projects.jsxrefactor.