Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tool to blend logs, taking timestamps into consideration #326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stefanv
Copy link
Contributor

@stefanv stefanv commented Jun 15, 2022

@mcoughlin Here is an alternative approach to skyportal/skyportal#3089 to address skyportal/skyportal#3084

This does not currently support the nginx log, but we can add that.

@mcoughlin
Copy link
Collaborator

@stefanv Oh wow that's nifty. Maybe it could optionally return the log string if called as a function for potential parsing and display of the health events on a dedicated page like I was thinking about in that other PR?

@stefanv
Copy link
Contributor Author

stefanv commented Jun 15, 2022

Is there a specific reason we need to expose the logs via the web?

@mcoughlin
Copy link
Collaborator

@stefanv i am thinking it would be very nice to at a glance (in an admin only page) to be able to see the logging rather than needing to be logged in and pulling down logs and such. It's mostly about convenience of rapid assessment.

@stefanv
Copy link
Contributor Author

stefanv commented Jun 16, 2022

Okay, maybe we should start with a tool and then talk about expanding scope. I'm a bit nervous, from a security perspective, to have log files served up. Perhaps it's fine, but then we may also want to consider whether we don't just want to use Google or GrayLog or similar.

@mcoughlin
Copy link
Collaborator

@stefanv sounds good. I am cool with your tool for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants