Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cap # responses instead of rejecting #2601

Merged
merged 1 commit into from
Feb 9, 2024
Merged

cap # responses instead of rejecting #2601

merged 1 commit into from
Feb 9, 2024

Conversation

scaprile
Copy link
Collaborator

@scaprile scaprile commented Feb 5, 2024

Fixes #2600

Instead of just rejecting records with more than 15 answers (formerly 10), limit ourselves to process no more than 10 of them; that is quite larger than the more deeply nested found so far (4). Works with the OP reference.
Reason: we can go rising the accepted number and nets may keep adding servers and providing lots of responses. We handle a reasonable number to get buried aliases for most known cases so far.

@cpq
Copy link
Member

cpq commented Feb 9, 2024

LGTM

mongoose.c Outdated Show resolved Hide resolved
@scaprile scaprile merged commit c8d45c9 into master Feb 9, 2024
62 of 63 checks passed
@scaprile scaprile deleted the dns branch February 9, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The maximum DNS response count should be a larger value
2 participants