mg_split -> mg_span. Remove mg_commalist #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpq
force-pushed
the
str
branch
4 times, most recently
from
ecdd2bc
to
665f456
Compare
|
Pushing - please review later. |
scaprile
reviewed
Feb 4, 2024
| @@ -3262,20 +3230,55 @@ static void test_sha1(void) { | |||
| test_sha1_str(")_)+_)!&^*%$#>>>{}}}{{{][[[[]]]", expected_hash_3); | |||
| } | |||
|
|
|||
|
|
|||
| static void test_split(void) { | |||
| bool mg_span(struct mg_str s, struct mg_str *a, struct mg_str *b, char sep) { | ||
| if (s.len == 0 || s.ptr == NULL) { | ||
| return false; // Empty string, nothing to span - fail | ||
| } else { |
There was a problem hiding this comment.
No actual need for this else clause
Comment on lines
+136
to
+140
| size_t len = 0; | ||
| while (len < s.len && s.ptr[len] != sep) len++; // Find separator | ||
| if (a) *a = mg_str_n(s.ptr, len); // Init a | ||
| if (b) *b = mg_str_n(s.ptr + len, s.len - len); // Init b | ||
| if (b && len < s.len) b->ptr++, b->len--; // Skip separator |
| @@ -42,7 +42,7 @@ static void sntp_cb(struct mg_connection *c, int ev, void *ev_data) { | |||
| if (ev == MG_EV_READ) { | |||
| int64_t milliseconds = mg_sntp_parse(c->recv.buf, c->recv.len); | |||
| if (milliseconds > 0) { | |||
| MG_INFO(("%lu got time: %lld ms from epoch", c->id, milliseconds)); | |||
| MG_DEBUG(("%lu got time: %lld ms from epoch", c->id, milliseconds)); | |||
There was a problem hiding this comment.
mmm... I'm not sure...
We have other events that are INFO, in MIP for example. Yes, those are more important...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.