fixup: smtp_batch: make compatible with introduction of bot_id#2692
Open
Lukas-Heindl wants to merge 1 commit intocerttools:developfrom
Open
fixup: smtp_batch: make compatible with introduction of bot_id#2692Lukas-Heindl wants to merge 1 commit intocerttools:developfrom
Lukas-Heindl wants to merge 1 commit intocerttools:developfrom
Conversation
bot_id as property was introduced in certtools#2509 which broke the output bot This closes certtools#2666.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
bot_idwas introduced as property in #2509 which broke the output botThis issue/incompatibility was noted in #2666.
Ideally we would had a test which would have spotted this issue prior to releasing the last version. But looking at the current tests, I'm unsure if we can cover this correctly (running an executable is not that nice for testing).