cli fileinputoutput: start bots with run instead of start #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
running the bot directly with `intelmqctl run bot-id process` ensures that at least one and exactly one message is processed until the process termination reducing accidental timing errors and alike
ghost
self-requested a review
|
But doesn´t it make sense to also check if it works when running a bot with start and stop? |
|
Definitely. For some reason start/stop works without troubles in the API test, but the CLI test cause[sd] troubles - I'm not sure what is causing them actually. |
|
Ah, interesting, I don't recall any problems with the CLI tests recently |
ghost
removed their request for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running the bot directly with
intelmqctl run bot-id processensuresthat at least one and exactly one message is processed until the process
termination reducing accidental timing errors and alike