gen.go: allow to customise the URL when generating #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolmen
force-pushed
the
feature/allow-custom-URL-when-generating
branch
from
c8d4bda
to
902606d
Compare
|
Rebased. |
"go run gen.go" now takes the URL from the command line. That URL is persisted in the go:generate line produced in certifi.go, so "go generate" will reuse that URL forever. This allows to easily fork the project to use a different URL (such as the original Mozilla) if someone doesn't trust mkcert.org.
dolmen
force-pushed
the
feature/allow-custom-URL-when-generating
branch
from
902606d
to
ac88b96
Compare
|
Rebased. Also improved to expose the source URL and the timestamp in the Go documentation of the |
|
Thanks for the merge! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch
go run gen.gonow takes the PEM source URL from the command line.That URL is persisted in the
go:generateline produced in certifi.go, sogo generatewill reuse that URL forever.This allows to easily fork the project to use a different URL (such as the PEM built by cURL developer from Mozilla sources: https://curl.haxx.se/ca/cacert.pem) if someone doesn't trust mkcert.org.
This PR still uses mkcert.org certificates as the source like before. It only makes forking easier.
Fork demo: