Skip to content

netlify: document deploy-preview security for forked pull requests #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wallrj-cyberark wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

netlify: document deploy-preview security for forked pull requests #2166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions netlify.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,16 @@
NEXT_PUBLIC_DOCS_SEARCH_INDEX_NAME = "cert-manager"
NEXT_PUBLIC_DOMAIN_URL = "https://cert-manager.io"

# Security (CWE-829): deploy previews for pull requests from public forks run
# untrusted code automatically, before any review. Do NOT add secrets to this
# block or to [build.environment] — they would be handed to fork builds. Secrets
# belong in [context.production.environment] or a production-scoped Netlify UI
# variable, which the sensitive-variable policy keeps from untrusted deploys:
# https://docs.netlify.com/build/environment-variables/get-started/#sensitive-variable-policy
Comment thread
wallrj-cyberark marked this conversation as resolved.
# This block is intentionally empty: deploy previews inherit the public values
# from [build.environment]; it exists only to make the "no secrets" rule visible.
[context.deploy-preview.environment]

# Prevent search engines from indexing preview sites for branch deploys. See
# - https://docs.netlify.com/routing/headers/#custom-headers-for-different-branch-or-deploy-contexts
# - https://developers.google.com/search/docs/crawling-indexing/block-indexing
Expand Down