docs(best-practice): fix HTTP01 NetworkPolicy examples - correct port, traffic flow, and selectors#2158
Open
lohitkolluri wants to merge 1 commit into
Conversation
…, traffic flow, and selectors Address all review comments on PR cert-manager#2151: - Fix solver port 8080 → 8089 to match cert-manager's acmeSolverListenPort (pkg/issuer/acme/http/http.go:49) - Correct the traffic flow documentation: the controller does NOT connect directly to solver pods. The self-check (testReachability) goes through port 80 via the ingress/load balancer, the same path the ACME server uses. - Replace the ingress rule source from cert-manager namespace to the ingress controller namespace (namespaceSelector-based), since the ingress controller is the component that routes traffic to solver pods on port 8089. - Remove the incorrect egress-from-controller-to-solver-pods example (wrong port, wrong selector, wrong flow - already covered by the existing port-80 egress rule for self-checks). - Remove the redundant API server port example (already documented in the Network Requirements list and covered by default egress rules). - Update the values.yaml comment on the port-80 self-check rule to accurately describe the traffic flow. Closes cert-manager#2151 Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes cert-manager#2334
Addresses all review comments from PR #2151 (karthikk022's original PR). Instead of amending that branch, this PR provides corrected examples based on review feedback and the prior art in closed PR #2110.
Root Cause of Incorrect Examples in #2151
The original NetworkPolicy examples had several errors:
acmeSolverListenPort = 8089inpkg/issuer/acme/http/http.go:49), not 8080.testReachability) goes through port 80 via the ingress/load balancer, following the same path the ACME server uses.What Changed
content/docs/installation/best-practice.md
public/docs/installation/best-practice/values.best-practice.yaml
What Was NOT Added (vs. Original #2151)
Testing
Signed-off-by: Lohit Kolluri lohitkolluri@gmail.com