Deploy cert-manager on Google Kubernetes Engine Tutorial - remove google domains #2062
Conversation
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Will squash and sign off once I've got this completed |
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
wallrj-cyberark
left a comment
There was a problem hiding this comment.
Thank you for flagging this — the Google Domains references in the GKE tutorial are indeed broken since the service was sold to Squarespace in 2023.
The current state of this PR only removes the Google Domains mention from the prerequisites line (line 41), but Section 4 ("Create a domain name for your website") still contains the bulk of the Google Domains content: step-by-step instructions pointing at domains.google.com, three Google Domains screenshots, and references to the Google Domains cart and DNS management UI.
The "Last Verified" date was also bumped to 14 April 2026, but the tutorial was not actually re-verified — the Google Domains content that immediately follows is broken.
As you noted in the PR description, this needs a decision on whether to:
- Replace Google Domains with a different registrar, or
- Make the domain section generic (remove registrar-specific steps and screenshots, keep the general A-record instruction)
I would suggest option 2 — making it generic. Registrar-specific screenshots and step-by-step instructions become stale when the registrar changes its UI, and the important concept for readers is "create an A record pointing to your ingress IP", not "click this button in this registrar's dashboard." The three Google Domains screenshots in static/images/getting-started/ should be removed as part of this change.
The "Last Verified" date should only be bumped when the tutorial is actually walked through end-to-end.
Are you still planning to complete this work? If so, I am happy to review a follow-up. If not, please let us know and we can either pick it up or close the PR.
Fixes #2061
Removing
google domainsin favor ofWill make changes once discussion on above issue pans out one way or another