Fixes to ElasticSearch's startup and VirusTotal reporting #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-ee-raidar
added
bug
LM-CT
commented
Mar 20, 2025
Comment on lines
+102
to
+117
| log.debug("Connecting to Elasticsearch.") | ||
| if self.client.ping(): | ||
| verified = True | ||
| failures = 0 | ||
| else: | ||
| verified = False | ||
| failures = 1 | ||
|
|
||
| while not verified and failures < 6: | ||
| time.sleep(10) | ||
| if not self.client.ping(): | ||
| failures += 1 | ||
| else: | ||
| verified = True | ||
|
|
||
| if not verified: |
There was a problem hiding this comment.
We already discussed this privately, but I'll try to re implement this using async methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes 3 issues I have encountered. They are:
For the first two, my changes delay Cuckoo3's startup by up to 60 seconds to give time for ElasticSearch to be fully functional and check if the first ElasticSearch endpoint in the config is using HTTPS as a transport, respectively.
For the latter, the
vtlibrary that is used to query VirusTotal changed the returned results class wrapper, so I added an additional check before serialising the returned object to disk.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
serialize_disk_json()function fromstrictcontainer.pyto take into account the new return class (WhistleBlowerDict) of the object, re-enabled the VT processor module and tested a bunch of files (known-good and known-bad) in Cuckoo to see if it would fail again.Checklist: