Skip to content
This repository has been archived by the owner on Feb 17, 2019. It is now read-only.

Major Refactor #101

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Major Refactor #101

wants to merge 2 commits into from

Conversation

PiyushPawar17
Copy link

  • Separate Components and Styles.
  • Consistent Coding Style.

@PiyushPawar17
Copy link
Author

@aashutoshrathi @anshumanv @Monal5031

@netlify
Copy link

netlify bot commented Jan 5, 2019 •
edited
Loading

Deployed at -

Built with commit 969224b

https://deploy-preview-101--cerebro-web.netlify.com

@anshumanv
Copy link
Member

image
Build fails for some reason

@PiyushPawar17
Copy link
Author

PiyushPawar17 commented Jan 5, 2019 •
edited
Loading

@anshumanv See index.html line 25. CSS has been imported from node_modules.

aashutoshrathi
aashutoshrathi reviewed Jan 5, 2019
View reviewed changes
src/components/EventList.js

class EventList extends React.Component {
render() {
let listEventsJsx = [];

if (this.props.event) {
console.log('Helloooo');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Monal5031
Monal5031 reviewed Jan 5, 2019
View reviewed changes
src/styles/Dashboard.css
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 newlines

@weekly-digest weekly-digest bot mentioned this pull request Jan 6, 2019
Open
aashutoshrathi
aashutoshrathi reviewed Jan 6, 2019
View reviewed changes
Copy link
Member

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting better 🤣
screenshot from 2019-01-06 12-00-58

One step closer to create-react-app cerebro-web

@PiyushPawar17
Copy link
Author

Create new repo.

@weekly-digest weekly-digest bot mentioned this pull request Jan 13, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aashutoshrathi aashutoshrathi aashutoshrathi left review comments

@Monal5031 Monal5031 Monal5031 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PiyushPawar17 @anshumanv @Monal5031 @aashutoshrathi