Change method used to retrieve rack status #1457
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small change to the way jsonapi-resources fetches the status code from the symbol. Currently, it makes use of
Rack::Utils::SYMBOL_TO_STATUS_CODE
, however this has started to break on new versions of Rack.A change introduced to Rack deprecates the status
:unprocessable_entity
in favour of:unprocessable_content
. By using theRack::Utils::SYMBOL_TO_STATUS_CODE
hash directly, no status is found due to the internal changes, which results injsonapi-resources
returning a0
status when there are validation errors.This is the first step to fixing the issue and is fully backwards compatible. In the future however, the status
:unprocessable_entity
should stopped being used entirely, however this will require checks to see which version of Rack is being used. I haven't tackled this here as I wasn't sure how best you wanted to handle this but I'd be happy to take a look at it in the future.This fixes the issue #1456
All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: