Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use records for joined resource Classes #1307

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lgebhardt
Copy link
Member

@lgebhardt lgebhardt commented Feb 8, 2020

resolves #1308

In addition this PR also adds some details about the relationship to the join_details as each join is setup and tracked. This is useful if you need to override the apply_joins method and need a window into the details as each join was setup. This was originally intended for the some experiments with the jsonapi-authorization gem, but I believe it could prove useful in any case where a better window into the join process is needed.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@lgebhardt lgebhardt force-pushed the use_records_for_joined_resources branch 3 times, most recently from 54f6024 to 79cd383 Compare February 10, 2020 14:24
@lgebhardt lgebhardt marked this pull request as ready for review February 10, 2020 14:59
@lgebhardt lgebhardt force-pushed the use_records_for_joined_resources branch 2 times, most recently from 8017e05 to 58bdf36 Compare January 25, 2021 16:50
@lgebhardt lgebhardt changed the base branch from master to release-0-10 February 4, 2022 19:16
@lgebhardt lgebhardt changed the base branch from release-0-10 to master February 4, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use records for joined resources
1 participant