CID v1 upgrade #267
Closed
CID v1 upgrade #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oed
reviewed
Sep 2, 2020
packages/ceramic-core/src/anchor/ethereum/ethereum-anchor-service.ts
Outdated
Show resolved
Hide resolved
oed
reviewed
Sep 3, 2020
Comment on lines
+48
to
+49
| "ipfs": "github:simonovic86/ipfs", | ||
| "ipfs-http-client": "github:simonovic86/ipfs-http-client" |
There was a problem hiding this comment.
The createDagJWS method that you provided in js-did library uses, amongst other things, CID v1 and ipld-dag-cbor v0.17.0 which is not compatible with one used in the latest IPFS release. That's why I forked the js-ipfs and tested it with the latest code. Because of this incompatibility, we're currently blocked with the integration.
|
IPFS team has released v |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decode