build: update rook version to v1.16.4 #5181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Praveen M <[email protected]>
mergify
bot
added
the
component/build
Madhu-1
reviewed
Feb 27, 2025
| @@ -49,7 +49,7 @@ VM_DRIVER=none | |||
| CHANGE_MINIKUBE_NONE_USER=true | |||
|
|
|||
| # Rook options | |||
| ROOK_VERSION=v1.14.9 | |||
| ROOK_VERSION=v1.16.4 | |||
There was a problem hiding this comment.
@iPraveenParihar https://github.com/ceph/ceph-csi/blob/ci/centos/mirror/images.txt#L10 This also need to be updated first to avoid pull limit issue
There was a problem hiding this comment.
I think its only required once to mirror the image repository? and not for each tag.
There was a problem hiding this comment.
I think its only required once to mirror the image repository? and not for each tag.
Yea, I was under wrong assumption.
|
/test ci/centos/mini-e2e/k8s-1.31 |
nixpanic
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Update
ROOK_VERSIONto latest available v1.16.4 to use in E2E testsDepends-On: #5182
Checklist:
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)