Fix cisco umbrella connections threshold name in --help output #5401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check: modem-enabled sim-status signal-strength sim-registration-status
|
Hello @rmorandell-pgum As always thanks for this contribution, but I think you push two things in? There is the bug fix but also a new plugin or I bad understand? |
|
Hi Lucie, yeah you are right .. sorry i was pushing from my main fork instead of the branch. i'll reopen it. |
|
Hi Lucie, yeah you are right .. sorry i was pushing from my main fork instead of the branch. i'll reopen it. |
|
No problem ;) I was just checking if I miss understand something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community contributors
Description
in the plugin all thresholds are *-status and not *-connectivity
Type of change