CTOR-1107-plugin-apps-monitoring-iplabel-ekara-restapi-mode-scenarios-wrong-index #5375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evan-Adam
force-pushed
the
CTOR-1107-plugin-apps-monitoring-iplabel-ekara-restapi-mode-scenarios-wrong-index
branch
from
62081ed to
608cf35
Compare
* Add message when api response is not what is expected * Correctly interpret index given by the api Refs:CTOR-1107
* Create a new function in api.pm used by both mode to get the list of scenario to monitor. Refs:CTOR-1107
* Create a new function in api.pm used by both mode to get the list of scenario to monitor. * Add two options Refs:CTOR-1107
Refs:CTOR-1107
Evan-Adam
force-pushed
the
CTOR-1107-plugin-apps-monitoring-iplabel-ekara-restapi-mode-scenarios-wrong-index
branch
from
608cf35 to
c6924a0
Compare
omercier
reviewed
Jan 10, 2025
| my $status_filter = {}; | ||
| my @get_param; | ||
|
|
||
| if (defined($self->{option_results}->{filter_status}) && $self->{option_results}->{filter_status}[0] ne '') { |
There was a problem hiding this comment.
No longer using is_empty()?
| [Documentation] Check Iplabel authentication | ||
| [Tags] monitoring iplabel restapi | ||
|
|
||
| Run rm -f /var/lib/centreon/centplugins/* |
There was a problem hiding this comment.
Not needed: the generic test suite does it already
| [Documentation] Check Iplabel authentication | ||
| [Tags] monitoring iplabel restapi | ||
|
|
||
| Run rm -f /var/lib/centreon/centplugins/* |
There was a problem hiding this comment.
Suggested change
| Run rm -f /var/lib/centreon/centplugins/* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug in ekara (iplabel) scenario monitoring where scenarios name where not correctly ordered.
Add new options to filter scenarios
Fixes # CTOR-1107 CTOR-123 CTOR-114
Type of change
How this pull request can be tested ?
See robot tests provided
Checklist