CTOR-666-plugin-hardware-server-lenovo-xcc-snmp-mode-hardware-system-health-memory-and-cpu-table-not-checked

[Evan-Adam]

Centreon team (internal PR)

Description

add 3 new modes for lenovo xcc hardware plugin and associated tests

Fixes # CTOR-666

Type of change

• Patch fixing an issue (non-breaking change)
• New functionality (non-breaking change)
• Functionality enhancement or optimization (non-breaking change)
• Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

the plugin should return critical when memory or health or cpu have any error.

Checklist

• I have followed the coding style guidelines provided by Centreon
• I have commented my code, especially hard-to-understand areas of the PR.
• I have rebased my development branch on the base branch (develop).
• In case of a new plugin, I have created the new packaging directory accordingly.
• I have implemented automated tests related to my commits.
  • Data used for automated tests are anonymized.
• I have reviewed all the help messages in all the .pm files I have modified.
  • All sentences begin with a capital letter.
  • All sentences end with a period.
  • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
• After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

[lucie-dubrunfaut]

I think for the verbose part of health, memory and cpu sensor name and status are inverted:

Checking disks
disk 'Anonymized 016' status is Normal [instance: 40].
disk 'Anonymized 104' status is Normal [instance: 41].
Checking raid volumes
raid volume 'Anonymized 215' status is Optimal [instance: 1].
Checking health
health 'Normal' status is Anonymized 144 [instance: 1].
health 'Normal' status is Anonymized 149 [instance: 2].
health 'Normal' status is Anonymized 127 [instance: 3].
health 'Normal' status is Anonymized 130 [instance: 4].
Checking cpu
'Normal' status is Anonymized 155 [instance: 1].
Checking memory
'Normal' status is DIMM_2 [instance: 1].
'Normal' status is DIMM_4 [instance: 2].
'Normal' status is DIMM_5 [instance: 3].
'Normal' status is DIMM_6 [instance: 4].
'Normal' status is DIMM_7 [instance: 5].
'Normal' status is DIMM_8 [instance: 6].
'Normal' status is DIMM_9 [instance: 7].
'Normal' status is DIMM_11 [instance: 8].