Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(packaging): nokia (formerly alcatel) isam snmp plugin #5087

Merged
merged 8 commits into from
Jul 5, 2024
Merged

new(packaging): nokia (formerly alcatel) isam snmp plugin #5087

merged 8 commits into from
Jul 5, 2024

Conversation

omercier
Copy link
Contributor

Description

The plugin has been there for a while but never packaged.

REFS: CTOR-594

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

No data for tests right now.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.

@omercier omercier marked this pull request as ready for review July 1, 2024 06:54
@omercier omercier requested review from a team as code owners July 1, 2024 06:54
Evan-Adam
Evan-Adam requested changes Jul 2, 2024
View reviewed changes
tests/resources/spellcheck/stopwords.t Outdated Show resolved Hide resolved
src/network/nokia/isam/snmp/mode/hardware.pm Outdated Show resolved Hide resolved
@omercier omercier requested a review from Evan-Adam July 4, 2024 15:44
omercier
omercier commented Jul 4, 2024
View reviewed changes
src/network/nokia/isam/snmp/mode/hardware.pm Outdated Show resolved Hide resolved
src/network/nokia/isam/snmp/mode/hardware.pm Outdated Show resolved Hide resolved
src/network/nokia/isam/snmp/mode/hardware.pm Outdated Show resolved Hide resolved
src/network/nokia/isam/snmp/mode/hardware.pm Outdated Show resolved Hide resolved
@omercier omercier force-pushed the CTOR-594-Alcatel-Isam-SNMP branch from 54eb490 to 2dfa4cd Compare July 5, 2024 15:35
@omercier omercier merged commit 085040f into develop Jul 5, 2024
16 checks passed
@omercier omercier deleted the CTOR-594-Alcatel-Isam-SNMP branch July 5, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuntoja tuntoja tuntoja approved these changes

@lucie-dubrunfaut lucie-dubrunfaut lucie-dubrunfaut approved these changes

@Evan-Adam Evan-Adam Evan-Adam approved these changes

@kduret kduret Awaiting requested review from kduret kduret is a code owner automatically assigned from centreon/owners-pipelines

@sdepassio sdepassio Awaiting requested review from sdepassio sdepassio is a code owner automatically assigned from centreon/owners-robot-e2e

@mushroomempires mushroomempires Awaiting requested review from mushroomempires

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omercier @tuntoja @lucie-dubrunfaut @Evan-Adam