Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a custom pathname #5085

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Conversation

ponchoh
Copy link
Contributor

@ponchoh ponchoh commented Jun 26, 2024

Add pathname variable to allow a custom pathname instead of http[s]://FQDN/centreon -> http[s]://FQDN/custom

Community contributors

Description

Add pathname variable to allow a custom pathname instead of:
http[s]://FQDN/centreon -> http[s]://FQDN/custom

Type of change

  • New functionality (non-breaking change)

How this pull request can be tested ?

  • set a new custom centreon_pathname
  • set a custom centreon_pathname
  • links should point to this new pathname
  • default is centreon

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • I have provide data or shown output displaying the result of this code in the plugin area concerned.

Add pathname variable to allow a custom pathname instead of
http[s]://FQDN/centreon -> http[s]://FQDN/custom
@ponchoh ponchoh requested a review from a team as a code owner June 26, 2024 20:08
@ponchoh ponchoh requested review from omercier and Tpo76 and removed request for omercier June 26, 2024 20:08
Tpo76
Tpo76 previously requested changes Jun 27, 2024
Copy link
Contributor

@Tpo76 Tpo76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please substitute line 118 with default => '/centreon'
Remove / everywhere is not needed (l 207, 213, 333,359, 481,594, 613, 620)
Rename option centreon-pathname with url-path for consistence with other RestAPI call in other plugins
Adjust help acconrdingly

@Tpo76 Tpo76 requested a review from omercier June 27, 2024 16:41
@Tpo76
Copy link
Contributor

Tpo76 commented Jun 27, 2024

@omercier did we bypass the spell check exception for this plugin ?
I can't recall

@lucie-dubrunfaut
Copy link
Contributor

@omercier did we bypass the spell check exception for this plugin ? I can't recall

Hello :)

You can add the label do-not-spellcheck. And then push an empty commit, this should disable the spellcheck test ;)

@lucie-dubrunfaut lucie-dubrunfaut added do-not-spellcheck avoid running the spellchecks in github action contribution labels Jul 1, 2024
@ponchoh ponchoh requested a review from Tpo76 July 2, 2024 14:17
- have a default value of "/centreon"
- create a check to add "/" if missing from url-path
Copy link
Contributor Author

@ponchoh ponchoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution do-not-spellcheck avoid running the spellchecks in github action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants