Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

layout: add Elasticsearch Trace exporters. #640

Merged
merged 1 commit into from
Mar 11, 2019
Merged

layout: add Elasticsearch Trace exporters. #640

merged 1 commit into from
Mar 11, 2019

Conversation

songy23
Copy link
Contributor

@songy23 songy23 commented Mar 11, 2019

@songy23 songy23 requested a review from odeke-em March 11, 2019 17:47
@songy23 songy23 requested a review from a team as a code owner March 11, 2019 17:48
odeke-em
odeke-em approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @songy23! I assume though we shall document this as well?

@songy23
Copy link
Contributor Author

songy23 commented Mar 11, 2019

I assume though we shall document this as well?

Sure I filed #641 to keep track.

@songy23 songy23 merged commit 859bc1f into census-instrumentation:master Mar 11, 2019
@songy23 songy23 deleted the java-exporters branch March 11, 2019 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@odeke-em odeke-em odeke-em approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@songy23 @odeke-em @googlebot