-
Notifications
You must be signed in to change notification settings - Fork 155
guides/http: document Java Jetty client integration #563
Conversation
Looks good. Couple of things.
|
Thank you for listing out your concerns @rghetia! Please see my responses below:
The example in the OpenCensus-Java repo is a full copy and pastable example for both the server and client but here we are documenting step by step for those who just want to use the client integration and the same for those who want to use the server integration. Otherwise, we'd just be dumping for them source code to go inspect. Please see what we've done for Go's net/http https://opencensus.io/guides/http/go/net_http/
Sure for running source code but not for prescriptive steps when users are integrating it to parts of their apps, when someone just wants to focus on the client, them reverse engineering source code yet not everyone runs both client and server. |
I didn't mean to dump the source code from the example directory but rather use code snippets from the example directory. Your step by step instructions are great. |
Oh I see. You have great examples in the OpenCensus-Java repo, but for this guide, the differences that I made were: |
import io.opencensus.contrib.http.jetty.client.OcJettyHttpClient; | ||
{{</highlight>}} | ||
|
||
#### Dependency management |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about gradle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roger that, I've added:
- Gradle
- Buildr
- Ivy
for the minimum additions of *http-jetty-client and *http-util dependencies.
SG. |
Please take a look at the update @rghetia and thanks for the initial review! |
LGTM |
Thank you for the review @rghetia! |
Document the Java Jetty client integration with a guide, an end-to-end example and screenshots. Updates #562
29a8c4a
to
3b6f96f
Compare
Document the Java Jetty client integration with a guide,
an end-to-end example and screenshots.
Updates #562