Custom end time for span (#95)

census-instrumentation · Jun 8, 2019 · 1aea7a9 · 1aea7a9
1 parent 82464ed
commit 1aea7a9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/opencensus-web-core/src/trace/model/span.ts b/packages/opencensus-web-core/src/trace/model/span.ts
@@ -261,7 +261,9 @@ export class Span implements webTypes.Span {
 
   /** Ends the span by setting `endTime` to now. */
   end() {
-    this.endPerfTime = performance.now();
+    if (this.endPerfTime === 0) {
+      this.endPerfTime = performance.now();
+    }
   }
 
   /** Forces the span to end. Same as `end` for opencensus-web. */

diff --git a/packages/opencensus-web-core/test/test-span.ts b/packages/opencensus-web-core/test/test-span.ts
@@ -95,6 +95,12 @@ describe('Span', () => {
     expect(span.endPerfTime).toBe(33);
   });
 
+  it('does not set endPerfTime when end is called, if endPerfTime is already set', () => {
+    span.endPerfTime = 22;
+    span.end();
+    expect(span.endPerfTime).toBe(22);
+  });
+
   it('sets endPerfTime when truncate is called', () => {
     spyOn(performance, 'now').and.returnValue(77);
     span.truncate();