Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

trace: add buffer limit #824

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Jul 12, 2018

  1. trace: add buffer limit

    This applies to all span data entities that are slices: Annotations,
    Links, and Message Events.
    
    At the limit, it pops the oldest sample off prior to appending the new
    sample. This should not cause an additional allocation.
    
    Each entity shares the same WithBufferLimit option following the YAGNI
    principle.
    
    Each test ensures 4 entities are added in total -- the first 2 are
    dropped and the last 2 remain. This should prevent off by 1 bugs.
    jgracenin committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    674874b View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2018

  1. trace: add limits for attributes, message events, and links.

    This applies limits to span data entities that are slices: Attributes,
    Message Events, and Links.
    
    The limits are default per the spec and can be globally changed with
    trace.ApplyConfig.
    
    The limits can also be changed per-span when creating a new span
    with one or more trace.StartOption.
    
    At the limit, it pops the oldest sample off prior to appending the new
    sample.
    
    Each test ensures 4 entities are added in total -- the first 2 are
    dropped and the last 2 remain. This should prevent off by 1 bugs.
    jgracenin committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    d3cc8ef View commit details
    Browse the repository at this point in the history