This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
RFC: add SpanContext.LocalRootSpanID #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpanContext should only hold things that are propagated between processes, which is not the case for this field.
rghetia
reviewed
Feb 14, 2019
rghetia
approved these changes
Feb 14, 2019
|
Thanks @rghetia. I hadn't intended for this to be merged before census-instrumentation/opencensus-specs#229 was resolved, but if you're happy for this to go in then I'm happy. |
It looks fine to me however I should not have merged until the spec is modified first. I'll roll it back unless we decide to update the spec based on this PR. |
|
Is this being added to the actual proto/spec? Right now it means the opencensus go deviates from the other implementations and they won't be able to work elastic. |
rghetia
added a commit
to rghetia/opencensus-go
that referenced
this pull request
Feb 20, 2019
…1029)" This reverts commit 57c0993. It was merged without updating the spec and resolving census-instrumentation/opencensus-specs#229
rghetia
added a commit
that referenced
this pull request
Feb 20, 2019
This reverts commit 57c0993. It was merged without updating the spec and resolving census-instrumentation/opencensus-specs#229
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion to census-instrumentation/opencensus-specs#229. These are the changes that would be necessary in order for Elastic APM to implement an exporter, as in elastic/apm-agent-go@master...axw:opencensus.
I'd appreciate feedback either here or on the spec issue, indicating whether this might be acceptable.