Fix bug with data type in JWT claims using FirebaseClient (#29)

celtic-project · Apr 4, 2022 · ab1e3f2 · ab1e3f2
1 parent a06aacf
commit ab1e3f2
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/src/Jwt/ClientInterface.php b/src/Jwt/ClientInterface.php
@@ -98,7 +98,7 @@ public function hasClaim($name);
      * @param string $name  Claim name
      * @param string $defaultValue  Default value
      *
-     * @return string The value of the claim with the specified name, or the default value if it does not exist
+     * @return string|array|object The value of the claim with the specified name, or the default value if it does not exist
      */
     public function getClaim($name, $defaultValue = null);
 

diff --git a/src/Jwt/FirebaseClient.php b/src/Jwt/FirebaseClient.php
@@ -168,7 +168,7 @@ public function hasClaim($name)
      * @param string $name  Claim name
      * @param string $defaultValue  Default value
      *
-     * @return string|array The value of the claim with the specified name, or the default value if it does not exist
+     * @return string|array|object The value of the claim with the specified name, or the default value if it does not exist
      */
     public function getClaim($name, $defaultValue = null)
     {
@@ -177,9 +177,6 @@ public function getClaim($name, $defaultValue = null)
         } else {
             $value = $defaultValue;
         }
-        if (is_object($value)) {
-            $value = (array) $value;
-        }
 
         return $value;
     }

diff --git a/src/Jwt/SpomkyLabsClient.php b/src/Jwt/SpomkyLabsClient.php
@@ -191,7 +191,7 @@ public function hasClaim($name)
      * @param string $name  Claim name
      * @param string $defaultValue  Default value
      *
-     * @return string The value of the claim with the specified name, or the default value if it does not exist
+     * @return string|array|object The value of the claim with the specified name, or the default value if it does not exist
      */
     public function getClaim($name, $defaultValue = null)
     {

diff --git a/src/Jwt/WebTokenClient.php b/src/Jwt/WebTokenClient.php
@@ -193,7 +193,7 @@ public function hasClaim($name)
      * @param string $name  Claim name
      * @param string $defaultValue  Default value
      *
-     * @return string The value of the claim with the specified name, or the default value if it does not exist
+     * @return string|array|object The value of the claim with the specified name, or the default value if it does not exist
      */
     public function getClaim($name, $defaultValue = null)
     {