feat: op-batcher must make sure blob is available before continuing #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build(deps): update go-da to v0.1.0 build(deps): update go-da to v0.2.0; add ctx da: add cli flags for da config da: add get timeout to da client build(deps): bump local-celestia-devnet to v0.12.7 fix(cli): fix da rpc check fix(cli): check return err fix(da): blob data source reuse DataFromEVMTransactions da: upgrade to go-da v0.5.0 feat(op-batcher): support disable eth fallback chore(op-batcher): refactor EthFallbackDisabledFlagName da: use env auth token if set feat: enable multi frame txs and frame size setting for calldata txs chore: add log for multiframetxs setting da: try using blobdata for eth fallback da: add gas price flag (ethereum-optimism#451) da: reuse useblobs for multiframetxs (ethereum-optimism#452) Add Github CI (ethereum-optimism#472) Cleanup Github CI workflow (ethereum-optimism#478) feat: allow to toggle Celestia in op-batcher and op-node (ethereum-optimism#498) feat: add op-celestia indexer (ethereum-optimism#503) fix: init op-node client da: use celestia-node client (ethereum-optimism#504) da: fix batcher submit (ethereum-optimism#511)
tuxcanfly
approved these changes
Sep 5, 2025
| continue | ||
| } | ||
|
|
||
| included, err := l.DAClient.Client.Blob.Included(ctx, height, namespace, proof, b.Commitment) |
Collaborator
There was a problem hiding this comment.
Would be good to benchmark this method for latency so we can tune the context timeout if required.
tuxcanfly
force-pushed
the
celestia-develop
branch
2 times, most recently
from
76133bc to
a3fc666
Compare
tuxcanfly
force-pushed
the
celestia-develop
branch
3 times, most recently
from
7730550 to
5748890
Compare
tuxcanfly
force-pushed
the
celestia-develop
branch
5 times, most recently
from
48f85d0 to
371be7b
Compare
tuxcanfly
force-pushed
the
celestia-develop
branch
3 times, most recently
from
7870c70 to
ac46c64
Compare
tuxcanfly
force-pushed
the
celestia-develop
branch
2 times, most recently
from
7ea1451 to
e409d7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes,
op-batchersuccessfully executesSubmit, but the blob isn’t immediately available afterward. As a result,op-nodefails toGetthe blob and thus throws a temporary error and keeps retrying until the blob can be retrieved.Ideally,
op-batchershould ensure the blob is fetchable before submitting the L1 transaction. That way, onceop-nodereceives the L1 transaction, the blob is guaranteed to be available for fetching right away.Let's discuss!