Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add go option in proto to be able to import pb.Proof #226

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

vgonkivs
Copy link
Member

Overview

Without go_option it is not possible to import pb.Proof in other proto files.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs self-assigned this Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #226 (c996475) into master (9d22de9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   65.20%   65.20%           
=======================================
  Files           6        6           
  Lines         891      891           
=======================================
  Hits          581      581           
  Misses        293      293           
  Partials       17       17           
Impacted Files Coverage Δ
pb/proof.pb.go 0.72% <ø> (ø)

@rootulp rootulp merged commit 3311036 into celestiaorg:master Jul 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants