Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update to square size 128 #1880

Merged
merged 3 commits into from
Jan 29, 2025
Merged

docs: update to square size 128 #1880

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e014f8
docs: update to square size 128
jcstein Jan 28, 2025
7dd88d5
Apply suggestions from code review
jcstein Jan 28, 2025
be33f65
Apply suggestions from code review
jcstein Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions how-to-guides/mainnet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,21 +52,21 @@ as a part of the CIP process.

There is a hard limit on the total blob size in a transaction, which is
determined by the effective maximum square size. Given that the current
governance maximum square size is 64, the total blob size in a transaction
must be slightly less than ~2 MiB, or 1,973,786 bytes to be exact.
governance maximum square size is 128, the total blob size in a transaction
must be slightly less than ~8 MiB, or 7,895,546 bytes to be exact.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Verify the exact byte count.

The stated exact byte count (7,895,546) differs from the calculation result in line 69 (7,896,602). This inconsistency should be resolved.

Apply this diff to fix the inconsistency:

-must be slightly less than ~8 MiB, or 7,895,546 bytes to be exact.
+must be slightly less than ~8 MiB, or 7,896,602 bytes to be exact.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
governance maximum square size is 128, the total blob size in a transaction
must be slightly less than ~8 MiB, or 7,895,546 bytes to be exact.
governance maximum square size is 128, the total blob size in a transaction
must be slightly less than ~8 MiB, or 7,896,602 bytes to be exact.

jcstein marked this conversation as resolved.
Show resolved Hide resolved

The following provides an approximation of the maximum block size:

- The maximum square size is 64x64, which gives us 4096 shares.
- One share is reserved for the PFB transaction, leaving us with 4095 shares.
- The maximum square size is 128x128, which gives us 16384 shares.
- One share is reserved for the PFB transaction, leaving us with 16383 shares.
- The first sparse share has 478 bytes available, and the remaining sparse
shares have 482 bytes each.

This can be calculated as follows:

<!-- markdownlint-disable MD013 -->

$\text{Total Bytes} = (1 \times 478 \, \text{bytes}) + (4094 \times 482 \, \text{bytes}) = 1,973,786 \, \text{bytes}$
$\text{Total Bytes} = (1 \times 478 \, \text{bytes}) + (16382 \times 482 \, \text{bytes}) = 7,896,602 \, \text{bytes}$

<!-- markdownlint-enable MD013 -->

Expand Down